fix: remove outlook protection for miro deep link #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @splagemann 👋🙂 Hmmm, I'm not sure. Have you tried Finicky? I have Finicky set up to handle something similar on my work machine, but for Teams links: module.exports = {
defaultBrowser: "Browserosaurus",
handlers: [
/**
* Microsoft Teams
*/
{
match: finicky.matchHostnames(["teams.microsoft.com"]),
browser: "com.microsoft.teams",
url: ({ url }) => ({ ...url, protocol: "msteams" }),
},
],
}; |
|
Hey, thanks for the answer. Interesting, so you're basically chaining those tools. Will experiment with that! Thanks |
|
Yep! I basically set Finicky as my default browser, and then B as Finicky's default 🤓 That way I get the rules engine and the UI selector. |
|
Works for me! Closed this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
This will remove the automatically ingested outlook protection link when deep linking into Miro.
More Detail
MS is automatically changing links in MS Teams or Outlook and prefixes them with a safety protection check. This basically destroys deep links into any application that is not a browser. I know that simply removing the link part is not a very clean solution, but by using the
miroappprotocol handler and checking for miro.com as part of the url I think it should be ok from a security perspective.There is maybe a more general solution for other deeplinks and/or other safety protection urls, so consider this as a first idea to address this problem.
This would solve one of my daily use-cases, but I do understand if this is considered a workaround and shouldn't go into this application.
Regards